Open
Conversation
YuriUfimtsev
left a comment
YuriUfimtsev
left a comment
There was a problem hiding this comment.
Что-то есть, но до полноценной реализации по условию еще далеко
YuriUfimtsev
reviewed
Oct 9, 2023
| [Params(12, 24, 48, 96, 192, 384, 768, 1536)] | ||
| public int Size; | ||
| private Matrix _fst; | ||
| private Matrix _sec; |
| { | ||
| foreach (var test in Tests) | ||
| { | ||
| yield return new TestCaseData(MatrixMultiplier.MultiThreadedMultiply, test); |
There was a problem hiding this comment.
От предупреждений компилятора надо избавиться
C#/forSpbu/MatrixMult/Matrix.cs
Outdated
| /// <summary> | ||
| /// Matrix elements | ||
| /// </summary> | ||
| private readonly int[,] _elements; |
There was a problem hiding this comment.
private-поля принято располагать выше: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1201.md.
Кстати, StyleCop стоит к сборкам подрубать, чтобы он сразу на несоответствия стандартам ругался
Co-authored-by: Yuri Ufimtsev <91129832+YuriUfimtsev@users.noreply.github.com>
Co-authored-by: Yuri Ufimtsev <91129832+YuriUfimtsev@users.noreply.github.com>
# Conflicts: # C#/forSpbu/MatrixMult.Benchmark/MatrixMultBenchmark.cs
Comment on lines
+21
to
+26
| public int Width => this._elements.GetLength(1); | ||
|
|
||
| /// <summary> | ||
| /// Constructs empty matrix | ||
| /// </summary> | ||
| public Matrix() |
There was a problem hiding this comment.
Всё-таки лучше как StyleCop советует: поля, конструкторы, свойства, методы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Тесты проводились на Ryzen 5 3600 (6 ядер 12 потоков); ns - микросекунды;
повторить можно так:
dotnet run --project MatrixMult.Benchmark -c Release